Skip to content

fix: Build the ChromeNotFoundError message as one string - #314

Merged
camdecoster merged 3 commits into
plotly:mainfrom
Blizzeq:fix/chrome-not-found-message
Sep 21, 2026
Merged

camdecoster merged 3 commits into
plotly:mainfrom
Blizzeq:fix/chrome-not-found-message

Conversation

@Blizzeq

@Blizzeq Blizzeq commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Description

Chromium passed the "browser not found" message to ChromeNotFoundError as two arguments, because of a stray comma between the f-strings. So str(e) printed a tuple:

('Browser not found. ... Local copy ignored: False. ', 'Path calculated:: /nonexistent/chrome.')

The message is now one string, and the doubled colon after "Path calculated" is gone. A test in test_chromium.py checks both. It fails on main.

@camdecoster camdecoster left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! These small typos are hard to see if you're not looking for them. Good eyes!

@camdecoster
camdecoster merged commit ff4d003 into plotly:main Sep 21, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants